Conversation
Renames `ReturnsResponse` to `ReturnsHttpResponse` for enhanced clarity and consistency within the HTTP client mocking API, explicitly indicating an HTTP response return type. Removes the redundant `ReturnsOK` helper method, streamlining the API by encouraging direct use of `ReturnsHttpResponse` with `HttpStatusCode.OK`. Refactors associated namespaces and renames the extension file for improved organization.
Keboo
force-pushed
the
cleanupHttpClient
branch
from
066a607 to
cfed086
Compare
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
ReturnsResponseextension method toReturnsHttpResponsefor improved clarity and consistency in mocking HttpClient responses.Removes the redundant
ReturnsOKhelper method to streamline the API, encouraging direct use ofReturnsHttpResponsewithHttpStatusCode.OK.Reorganizes the HTTP response extension methods into a dedicated file and adjusts their namespace for better code structure and discoverability.